forgot to update smoothed price with price scale in switchboard case #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.0.3_upcoming #175 +/- ##
==================================================
Coverage ? 84.26%
==================================================
Files ? 51
Lines ? 19744
Branches ? 0
==================================================
Hits ? 16637
Misses ? 3107
Partials ? 0 ☔ View full report in Codecov by Sentry. |
nope-finance
approved these changes
Dec 15, 2023
| @@ -531,7 +531,7 @@ fn _refresh_reserve<'a>( | |||
| // currently there's no way to support two prices without a pyth oracle. So if a reserve | |||
| // only supports switchboard, reserve.smoothed_market_price == reserve.market_price | |||
| if reserve.liquidity.pyth_oracle_pubkey == solend_program::NULL_PUBKEY { | |||
| reserve.liquidity.smoothed_market_price = market_price; | |||
| reserve.liquidity.smoothed_market_price = market_price.try_mul(reserve.price_scale())?; | |||
There was a problem hiding this comment.
isn't it wasteful to multiply again?
0xripleys
force-pushed
the
oracle_multiplier_bugfix
branch
from
b3b1b2a to
b1ae6bb
Compare
nope-finance
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.