Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs remove deprecated since 0.4.7 functions #3

Merged
merged 2 commits into from
May 10, 2018
Merged

Conversation

bmacnaughton
Copy link
Contributor

lchown, lchownSync, lchmod, and lchmondSync have been deprecated since 0.4.7. They have been replaced with chown, chownSync, chmod, and chmodSync. It turns out that it is not implemented on linux at all (nodejs/node#19868) but somehow seems to have been missed by the testing. Updating gulp and/or gulp-mocha caused the tests for those functions to fail.

@bmacnaughton bmacnaughton merged commit 70a5d5a into master May 10, 2018
@bmacnaughton bmacnaughton deleted the fs-test-fixes branch May 10, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant