-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-11537 NH-11539 add tox linting and formatting #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
force-pushed
the
NH-11537-add-linting-formatting
branch
from
November 22, 2022 00:40
6ac304b
to
0374bea
Compare
cheempz
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @tammy-baylis-swi for the analysis and writeup as always. Note that CodeQL may not be available to us yet per separate Jira/email thread that I just cc'd you in.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds NH Python code linting and formatting ways similar to OTel Python's as far as I understand right now:
I've ported over a lot of the OTel Python settings for what to specifically exclude, how to format the results, which rules to disable, etc. I've not really included anything from AO Python.
black
andisort
can perform some autofixing. There is no autofixing available withflake8
and there probably never will be. I think it's the same forpylint
but I can't find it in its own official docs.This doesn't enforce formatting with any hooks nor upon-PR action triggers yet. I think I want to do this:
I also think I'll be able to test the CodeQL GH workflow once this has been merged to
main
.Please let me know what you think! 😺