NH-26173 Add sdist and wheel extension checks at package build

[tammy-baylis-swi]

Add sdist and wheel extension checks at package build as part of the make package target. make package is called locally or by GH workflows via package_solarwinds_apm (by all of TestPyPI, PackageCloud, PyPI publishes). This way, the extensions are checked immediately after sdist/wheel creation and exit 1 if they fail. For the GH workflows, this should stop everything before the actual upload step.

To implement this I've split up the existing install test bash scripts so that the check sdist/wheel calls can be accessed separately by Makefile without doing the full install, instrument, and startup checks (is that what we want?)

I've been tested this locally with:

1. ./run_docker_dev then make package
2. cd tests/docker/install and MODE=local docker-compose up py3.7-install-alpine3.13
3. Same as (2) but MODE=testpypi

So far this hasn't caught anything unusual like what happened with solarwinds-apm 0.2.0 publish to PyPI.

I think I'll have to wait until our next TestPyPI/PackageCloud/PyPI publish to make sure this works there too.

Bonus: I've also updated some of the GH workflows themselves. The PyPI release PRs will be a bit more informative than this one and will be drafts because most times an additional commit for changelog update is needed. The publish and release creation workflow should also be a bit more clean than this run; the 2nd action now has a name and the third action gives some separation.

Please let me know what you think!

[cheempz]

LGTM and your approach of splitting them up makes sense to me @tammy-baylis-swi! I left some minor comments, none are blockers :)

[cheempz]

Does the Create draft release job need these above steps to checkout the repo (maybe?) and build the package (seems no?)

[tammy-baylis-swi]

Yes, package_solarwinds_apm isn't needed. Removed in 0f755db.

I thiiiink the checkout isn't needed either for gh release create if we specify --repo. This doc doesn't make it super clear to me: https://cli.github.com/manual/gh_release_create. But this blog (haha) says:

In fact GitHub releases created by any means trigger the package build and upload workflow. For example I could run GitHub CLI’s gh release create command from any directory on my local machine. This doesn’t require me to have a local copy of the project or to have anything setup locally other than GitHub CLI itself:

$ gh release create --repo seanh/gha-python-packaging-demo --generate-notes 0.0.1
https://github.com/seanh/gha-python-packaging-demo/releases/tag/0.0.1

So I'm going to give this a try and report back!

[tammy-baylis-swi]

...Actually don't think I can test this as is until next release. Changed in 70e469b and trying something else.

[tammy-baylis-swi]

We do need the checkout! This run failed: https://github.com/appoptics/solarwinds-apm-python/actions/runs/3441033073/jobs/5740153872

Run git config user.name "GitHub Actions"
  git config user.name "GitHub Actions"
  git config user.email noreply@github.com
  shell: /usr/bin/bash -e {0}
  env:
    RELEASE_NAME: rel-0.[2](https://github.com/appoptics/solarwinds-apm-python/actions/runs/3441033073/jobs/5740153872#step:2:2).2
fatal: not in a git directory
Error: Process completed with exit code 12[8](https://github.com/appoptics/solarwinds-apm-python/actions/runs/3441033073/jobs/5740153872#step:2:9).

[cheempz]

Nice!

[cheempz]

Nit: may be clearer to say something like "only testing the cp38 x86_64 wheel under ${APM ROOT}"

[tammy-baylis-swi]

Sounds good! Changed in 5496b3b

[cheempz]

Minor, the check-* tasks already depend on the sdist and manylinux-wheels tasks, so don't need them in the package task... or if it seems clearer, the check-* tasks don't have them as deps.

[tammy-baylis-swi]

Yes good call! Addressed in 5496b3b

[tammy-baylis-swi]

Thanks @cheempz ! I've addressed your comments. We will have to keep the checkout for the Create_release. Please let me know if anything else!

[cheempz]

Good to know, thanks for the revisit @tammy-baylis-swi!