NH-98561 Remove support of SW_APM_EXPORT_LOGS_ENABLED #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -173,7 +172,9 @@ def _configure_otel_components( | |||
| apm_config, | |||
| oboe_api, | |||
| ) | |||
| self._configure_logs_exporter(apm_config) | |||
|
|
|||
| # Always setup logs exporter | |||
There was a problem hiding this comment.
This will always be called for now. Currently _configure_logs_exporter includes a check of OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED and if False does not set up log handling nor exporter. This will change in another upcoming PR.
Comment on lines
+149
to
+151
| mock_config_logs_exp.assert_called_once_with( | ||
| mock_apmconfig_enabled_legacy | ||
| ) |
There was a problem hiding this comment.
See above comment.
Comment on lines
-308
to
-309
| if self._instrumentor_logs_enabled is False: | ||
| kwargs["logger_provider"] = NoOpLoggerProvider() |
There was a problem hiding this comment.
No upstream instrumentor supports this kwarg at the moment, so this does nothing.
cheempz
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this will merge into feature branch
NH-79205-otlp-by-default.This removes support of
SW_APM_EXPORT_LOGS_ENABLED/exportLogsEnabled. The value is no longer stored internally. If configured by user, a warning is logged.This is a little aggressive but will be part of a major release that breaks larger default signal export behaviours.