NH-88067 setdefault for disabling aws-lambda if outside lambda #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
deleted the
NH-88067-setdefault-disable-aws-lambda-inst
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates distro
setdefaultto disableaws-lambda(AwsLambdaInstrumentor) if outside lambda environment. Users can still setOTEL_PYTHON_DISABLED_INSTRUMENTATIONS, but if they do then they need to addaws-lambdato the list.The config that include
aws-lambdastops incorrect load_instrumentor calls by upstream auto-instrumentation if outside of lambda, which would give these uncomfortable logs:Added tox test passes on this PR. See ticket comment for manual testing.