Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-80452 Ignore export logs config when AO collector #400

Merged
merged 2 commits into from
Jul 30, 2024
Merged

NH-80452 Ignore export logs config when AO collector #400

merged 2 commits into from
Jul 30, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Jul 30, 2024 •
edited
Loading

Ignores SW_APM_EXPORT_LOGS_ENABLED / exportLogsEnabled if collector is AO, then sets internally to False. Customer can still manually configure OTLP logs export with OTEL_* env vars that take precedence (see #393).

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review July 30, 2024 19:06
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner July 30, 2024 19:06
cheempz
cheempz approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tammy-baylis-swi!

@tammy-baylis-swi tammy-baylis-swi merged commit 114021f into main Jul 30, 2024
11 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-80452-ignore-expt-logs-when-ao-v2 branch July 30, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @cheempz