Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-79315 Update log warning to error if Python 3.7 #376

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Jun 4, 2024

Updates the startup case for logging a warning to logging an error if using Python 3.7, which neither APM Python nor OTel Python supports now.

APM Python will still continue to (try to) configure Otel and the SDK will run.

Is this too strong, or not strong enough?

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review June 4, 2024 18:37
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner June 4, 2024 18:37
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, error level seems appropriate.

@tammy-baylis-swi tammy-baylis-swi merged commit da86e42 into main Jun 4, 2024
11 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-79315-rm-py37-log-case branch June 4, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants