Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-74450 Custom distro load_instrumentor catches and logs #332

Merged
merged 1 commit into from
Mar 5, 2024
Merged

NH-74450 Custom distro load_instrumentor catches and logs #332

merged 1 commit into from
Mar 5, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

Updates custom distro load_instrumentor method to catch and log errors at auto-instrumentation, such as grpcio ImportError when the wrong distro for a particular architecture is used (e.g. arm64 instead of x86_64). Example output, instead of a multi-line stacktrace:

2024-03-05 17:58:41,108 [ solarwinds_apm.distro ERROR p#17.140002353669952] Could not load instrumentor grpc_aio_client: cannot import name 'cygrpc' from 'grpc._cython' (/opt/python/grpc/_cython/__init__.py)

@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner March 5, 2024 18:12
@tammy-baylis-swi tammy-baylis-swi merged commit 5606710 into main Mar 5, 2024
11 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-74450-catch-load-instrumentor-error branch March 5, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael-theriault-swi raphael-theriault-swi raphael-theriault-swi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @raphael-theriault-swi