Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-70772 Add formatter to rotatingfilehandler #320

Merged
merged 1 commit into from
Feb 21, 2024
Merged

NH-70772 Add formatter to rotatingfilehandler #320

merged 1 commit into from
Feb 21, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

Adds formatter to RotatingFileHandler so that logs in contents of SW_APM_LOG_FILEPATH match what the StreamHandler already does. Example logs

2024-02-21 17:04:46,652 [ solarwinds_apm.configurator WARNING  p#1.281472885620768] Agent disabled. Not sending init message.
2024-02-21 17:04:49,552 [ solarwinds_apm.api DEBUG    p#1.281472856486304] Cannot cache custom transaction name abc because agent not enabled; ignoring

@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner February 21, 2024 17:08
cheempz
cheempz approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tammy-baylis-swi tammy-baylis-swi merged commit 498af3e into main Feb 21, 2024
11 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-70772-add-filehandler-formatter branch February 21, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @cheempz