NH-66126 Exporter defaults based on configured protocol #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
force-pushed
the
NH-66126-map-protocol-to-exporters
branch
from
6cb86a7 to
6efcff1
Compare
This reverts commit c61a31a.
Comment on lines
+341
to
+350
| logger.debug( | ||
| "Setting trace with SimpleSpanProcessor using %s", | ||
| exporter_name, | ||
| ) | ||
| span_processor = SimpleSpanProcessor(exporter) | ||
| else: | ||
| logger.debug( | ||
| "Setting trace with BatchSpanProcessor using %s", | ||
| exporter_name, | ||
| ) |
There was a problem hiding this comment.
Unrelated: updates some misleading debug lines
cheempz
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
LGTM, thanks for the nice PR description @tammy-baylis-swi!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, metrics and traces exporter defaults depended on is_lambda (see #217).
After this PR, the defaults don't depend on lambda. They instead depend on
OTEL_EXPORTER_OTLP_PROTOCOLwhich we require for otlp exporting in any environment.If Protocol is
http/protobuf:OTEL_METRICS_EXPORTERdefaults to otlp_proto_httpOTEL_TRACES_EXPORTERdefaults to otlp_proto_httpIf Protocol is
grpc:OTEL_METRICS_EXPORTERdefaults to otlp_proto_grpcOTEL_TRACES_EXPORTERdefaults to otlp_proto_grpcIf Protocol is anything else or unset:
OTEL_METRICS_EXPORTER. User must configure metrics exporters else none will initialize.OTEL_TRACES_EXPORTERdefaults to solarwinds_exporterNote that the above are for default values. Any combination of env vars to specify protocol, exporter, endpoint will still be respected.
This does deviate from the Otel default distro, which uses otlp_proto_grpc by default.
We now start packaging otlp_proto_grpc with our layer to better match Otel's layer and because export by grpc is available and working and the default for Otel Python.