NH-65067 Remove support for experimental flag #308
Conversation
tammy-baylis-swi
force-pushed
the
NH-65067-rm-exptl-flag-support
branch
from
d181175 to
7ee5c8b
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from .fixtures.sampler import ( | ||
| fixture_swsampler, | ||
| fixture_swsampler_is_lambda, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import Note test
There was a problem hiding this comment.
Sorry bot I am not refactoring the fixtures in this PR
tammy-baylis-swi
force-pushed
the
NH-65067-rm-exptl-flag-support
branch
from
f9f08bb to
b945323
Compare
| @@ -116,7 +116,11 @@ def _configure_otel_components( | |||
| if apm_config.agent_enabled: | |||
| # set MeterProvider first via metrics_exporter config | |||
| self._configure_metrics_exporter(apm_config) | |||
| # This processor only defines on_start | |||
There was a problem hiding this comment.
I added this and other comments because I keep forgetting the reasons for the processors registration order.
| if not apm_config.agent_enabled: | ||
| logger.error("Tracing disabled. Cannot set metrics exporter.") | ||
| return |
There was a problem hiding this comment.
I've removed this check because the caller is already doing the enabled check (_configure_otel_components further up)
| logger.debug( | ||
| "Experimental otel_collector flag not configured. Creating meter manager as no-op." | ||
| ) | ||
| self.apm_meters = NoopMeterManager() |
There was a problem hiding this comment.
This is no longer necessary because this processor will not be initialized at all if no OTEL_METRICS_EXPORTER. Keeping the no-op class for now in case new config features/refactor later on.
Removes support of the
experimentalflag required to init components for OTLP generation and export.The presence of
OTEL_METRICS_EXPORTERbecomes the condition for whether or not metrics meters, exporters, readers, MeterProvider, and related span processors are initialized. I don't love where the checks are but this is easy and hopefully clear enough for now.The default values for
OTEL_METRICS_EXPORTERare the same and depend on is_lambda; see #217. The check for is_lambda also stays the same.Please let me know what you think!