Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-70998 OTLP response_time metrics in milliseconds #298

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Feb 1, 2024

Fixes OTLP response_time metrics so they're reported in milliseconds (not nanoseconds, as before).

Here is a test otelcol metrics message following a request to a route with a time.sleep(3) included:

Metric #0
Descriptor:
     -> Name: trace.service.response_time
     -> Description: measures the duration of an inbound HTTP request
     -> Unit: ms
     -> DataType: Histogram
     -> AggregationTemporality: Cumulative
HistogramDataPoints #0
Data point attributes:
     -> sw.is_error: Str(false)
     -> http.status_code: Int(200)
     -> http.method: Str(GET)
     -> sw.transaction: Str(unused)
StartTimestamp: 2024-02-01 18:28:18.418123297 +0000 UTC
Timestamp: 2024-02-01 18:28:18.420461838 +0000 UTC
Count: 1
Sum: 3017.000000
Min: 3017.000000
Max: 3017.000000

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review February 1, 2024 18:29
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner February 1, 2024 18:29
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @tammy-baylis-swi pending one question.

@tammy-baylis-swi tammy-baylis-swi merged commit d42dbcd into main Feb 1, 2024
11 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-70998-otlp-span-time-ms branch February 1, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants