Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-70998 PeriodicExportingMetricReader with export_interval infinity #297

Merged
merged 1 commit into from
Feb 1, 2024
Merged

NH-70998 PeriodicExportingMetricReader with export_interval infinity #297

merged 1 commit into from
Feb 1, 2024

Conversation

tammy-baylis-swi
Copy link
Contributor

We init PeriodicExportingMetricReader with export interval infinity so reading is no longer periodic.

@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner February 1, 2024 02:18
cheempz
cheempz approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 same thought as for the histogram temporality delta, that in the future we may want to limit "explicit reading" to only certain scenarios (like lambda). Just a future mental note :)

@tammy-baylis-swi tammy-baylis-swi merged commit 8bb1ad4 into main Feb 1, 2024
11 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-70998-interval-millis branch February 1, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @cheempz