NH-70998 Set histogram preferred temporality delta #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
changed the title
cheempz
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
LGTM, thanks @tammy-baylis-swi for highlighting the impact of this change.
From quick read of info online, the temporality to choose comes down to what the backend supports--since we're building that out in SWO based on delta, and metrics exporting is still behind the experimental setting, it seems fine to go with setting it on all exporters for now.
In the future we may want more flexibility which might only be possible by creating a SWO-specific exporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #289. EDIT: that's done thanks!
Sets preference for all histograms to report using delta aggregation, including
response_time.The entry point
loadis called for any metrics exporters specified byOTEL_METRICS_EXPORTER. Otel Python's otlp metrics exporters for http and grpc both accept optionalpreferred_temporality. I don't think there are others in Otel Python. If someone configures a custom metrics exporter, it needs to also accept temporality or general **kwargs, else this might error.Please let me know what you think!