NH-67051 Add tests for instrumented_python_framework_versions helper #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tests/unit/test_configurator/test_configurator_add_all_instrumented_versions.py
Fixed
Show fixed
Hide fixed
tests/unit/test_configurator/test_configurator_add_all_instrumented_versions.py
Fixed
Show fixed
Hide fixed
tests/unit/test_configurator/test_configurator_add_all_instrumented_versions.py
Fixed
Show fixed
Hide fixed
tests/unit/test_configurator/test_configurator_add_all_instrumented_versions.py
Fixed
Show fixed
Hide fixed
tests/unit/test_configurator/test_configurator_add_all_instrumented_versions.py
Fixed
Show fixed
Hide fixed
cheempz
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the big configurator helper method
_add_all_instrumented_python_framework_versionsused to construct the reporter init message. It's got lots ofifbecause Python module version info storage is not consistent.Includes one tiny src code change to capitalize the framework keys being written. For example before it wrote something like
"Python.urllib.Version": "3.9"; now it writes"Python.Urllib.Version": "3.9"like the function docstring says it should.Tests last passed at 8319664, before reverting back to c-lib 13.