NH-67051 Add report_init_event tests #240
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @pytest.fixture(name="mock_extension_status_code_invalid_protocol") | ||
| def mock_extension_status_code_invalid_protocol(mocker): | ||
| return get_extension_mocks(mocker, 2) |
There was a problem hiding this comment.
Great addition of these different scenarios "ok", "already_init" and "invalid_protocol"! It's pointing out something a little subtle--we're checking the reporter initialization status as part of reporting the Init event, and actually ignoring the return code from the report Init event sendStatus call.
There was a problem hiding this comment.
LGTM, great to see these tests which will help with regression as we consider upcoming changes @tammy-baylis-swi! One future possibility is to have an explicit check of the "extension" (whether full oboe with reporter, or minimal Lambda api) init/loading status rather than as part of sending Init event.
Thank you @cheempz ! New ticket here: https://swicloud.atlassian.net/browse/NH-68251 |
Adds report_init_event tests!! Tricky mocks for this one.
Tests pass with c-lib 14 (5d7dcee) before revert