Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-67051 Add mixed exporter config tests #235

Merged
merged 3 commits into from
Nov 23, 2023
Merged

NH-67051 Add mixed exporter config tests #235

merged 3 commits into from
Nov 23, 2023

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Nov 22, 2023 •
edited
Loading

Adds more configurator tests for exporter config, where OTEL_TRACES_EXPORTER or OTEL_METRICS_EXPORTER has more than one name.

Passes when c-lib 14 (88128e5)

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review November 22, 2023 23:48
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner November 22, 2023 23:48
Base automatically changed from NH-67051-add-metrics-exporter-config-tests to main November 22, 2023 23:48
cheempz
cheempz approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tammy-baylis-swi tammy-baylis-swi merged commit dd2503f into main Nov 23, 2023
1 of 9 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-67051-more-exporter-config-tests branch November 23, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @cheempz