Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-67051 Add span processor config tests #233

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

tammy-baylis-swi
Copy link
Contributor

Add span processor configurator unit tests.

@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner November 22, 2023 20:16
Base automatically changed from NH-67051-add-metrics-exporter-config-tests to main November 22, 2023 23:48
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tammy-baylis-swi :)

@tammy-baylis-swi tammy-baylis-swi merged commit f28e0fc into main Nov 23, 2023
3 of 19 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-67051-add-processor-config-tests branch November 23, 2023 00:02
Comment on lines +13 to +16
from .fixtures.apm_config import (
mock_apmconfig_enabled,
mock_apmconfig_enabled_expt,
)

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'mock_apmconfig_enabled' is not used.
Import of 'mock_apmconfig_enabled_expt' is not used.
mock_apmconfig_enabled,
mock_apmconfig_enabled_expt,
)
from .fixtures.meter_manager import mock_meter_manager

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'mock_meter_manager' is not used.
mock_apmconfig_enabled_expt,
)
from .fixtures.meter_manager import mock_meter_manager
from .fixtures.txn_name_manager import mock_txn_name_manager

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'mock_txn_name_manager' is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants