NH-64716 Fix lambda extension setup and OboeAPI call #224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lambda extension linking by adding lambda env var checks to
CustomBuildExt.run()
in setup.py. The Make targetwrapper
stays the same. The symlinks (liboboe.so
andliboboe.so.0
) are created to point to the appropriate, already-downloaded c-lib .so at time of APM Python installation, including when run on local. This makes it easier to test lambda behaviour on local as long as the twoLAMBDA
env vars are set in the test environment. This stops SSL issue and incorrect sampling decisions I was seeing during testing.I also simplified setup.py by removing
CustomBuildExtLambda
and its uses, and moving what it did intoCustomBuildExt
. Lambda layer builds work by usingCustomBuildExt
now.Fixes OboeAPI call to use the same args as when calling Context to get sampling decision.
Tests pass at 63ab599, then I reverted the c-lib 14 stg commit.