NH-65069 Lambda layer 0.8 MB decrease #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
changed the title
|
Ready for review. Not sure why reviewers didn't automatically add when I first put this in. |
cheempz
previously approved these changes
Nov 15, 2023
Makefile
Outdated
| aws-lambda: check-zip wrapper | ||
| @if [ -f ./dist/solarwinds_apm_lambda_${platform}.zip ]; then \ | ||
| echo -e "Deleting old solarwinds_apm_lambda_${platform}.zip"; \ | ||
| rm ./dist/solarwinds_apm_lambda_${platform}.zip; \ | ||
| fi | ||
| rm -rf ./tmp | ||
| rm -rf ./tmp-lambda |
There was a problem hiding this comment.
Minor curiosity why this and a few other commands below don't use ${target_dir} instead?
There was a problem hiding this comment.
No reason! Fixed in 29e600c 😸
|
Thank you @cheempz ! One more look when you have a moment please. |
cheempz
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shrinks APM Python lambda layer zip size from 9.5 MB to 8.7 MB by removing super-upstream deps that don't seem to be needed for actual instrumentation. Otel Python does something similar in its builds: https://github.com/open-telemetry/opentelemetry-lambda/blob/main/python/src/otel/Dockerfile#L19-L20
Also removes an unused target
publish-lambda-layer-rcand changes the temp dir name used for lambda publish, as it was conflicting with this dir for cert stuff.Tested that instrumentation still works by merging this with Settings API PoC branch, building and uploading new layer, attaching layer to function, and invoking function. Traces and metrics export still work: