NH-65075 Add support for SW_APM_TRANSACTION_NAME #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
xuan-cao-swi
previously approved these changes
Oct 20, 2023
|
Needed a quick tidy and changelog update in f68ec42. @xuan-cao-swi may I please have another look? 😃 |
xuan-cao-swi
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for environment variable
SW_APM_TRANSACTION_NAMEor JSON config file"transactionName"to apply one custom name to all transactions. This is being introduced now for lambda instrumentation but is available outside of lambda too.Precendence in decreasing order:
solarwinds_apm.api.set_transaction_nameSW_APM_TRANSACTION_NAMEor config file KVTested manually with testbed flask_apm_api_app. When the
set_transaction_namecall is commented out andSW_APM_TRANSACTION_NAMEis set, the env var is used to name the transactions. When API call commented back in, the API's name is used.