-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-41991 Verify Installation tests use ec2 action runners #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael-theriault-swi
approved these changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running a tiny bit faster I see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces old
verify_installation
workflow that used regular GH action runners + QEMU with newverify_installation
that uses our ec2-runner-action. Thank you Raph for all your tips through this one!Much faster and no more random failures! Example run: https://github.com/solarwindscloud/solarwinds-apm-python/actions/runs/5135753921
Both x86 and aarch64 wheel installations are being tested, e.g.:
The Python version X Linux distro coverage is similar to the old workflow. Neither workflow has much py3.10/3.11-on-Ubuntu coverage because of https://swicloud.atlassian.net/browse/NH-31430. py3.12 isn't covered at all because it hasn't been released yet, though an alpha version is available in some public images. I will address these in future PRs.