Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-41991 Verify Installation tests use ec2 action runners #156

Merged
merged 27 commits into from
May 31, 2023

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented May 31, 2023

Replaces old verify_installation workflow that used regular GH action runners + QEMU with new verify_installation that uses our ec2-runner-action. Thank you Raph for all your tips through this one!

Much faster and no more random failures! Example run: https://github.com/solarwindscloud/solarwinds-apm-python/actions/runs/5135753921

Both x86 and aarch64 wheel installations are being tested, e.g.:

# install-tests (amazonlinux:2023, x64)

Using provided MODE=pypi for check_wheel test.
Set WHEEL_FILENAME=manylinux_2_27_x86_64.manylinux_2_28_x86_64.whl based on platform for check_wheel test.
# install-tests (amazonlinux:2023, arm64)

Using provided MODE=pypi for check_wheel test.
Set WHEEL_FILENAME=manylinux_2_27_aarch64.manylinux_2_28_aarch64.whl based on platform for check_wheel test.

The Python version X Linux distro coverage is similar to the old workflow. Neither workflow has much py3.10/3.11-on-Ubuntu coverage because of https://swicloud.atlassian.net/browse/NH-31430. py3.12 isn't covered at all because it hasn't been released yet, though an alpha version is available in some public images. I will address these in future PRs.

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review May 31, 2023 17:30
@tammy-baylis-swi tammy-baylis-swi requested a review from a team May 31, 2023 17:30
Copy link
Member

@raphael-theriault-swi raphael-theriault-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running a tiny bit faster I see

@tammy-baylis-swi tammy-baylis-swi merged commit 8047dc7 into main May 31, 2023
@tammy-baylis-swi tammy-baylis-swi deleted the NH-41991-arm64-tests-update branch May 31, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants