NH-34752 Add calculate_tracing_mode tests and fixture #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+12
to
+15
| from .fixtures.sampler import ( | ||
| fixture_swsampler, | ||
| fixture_swsampler_txnfilters, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import
There was a problem hiding this comment.
Dismissing this because they're actually used. pytest needs these imports for the below tests to use the fixtures via method args.
raphael-theriault-swi
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for
calculate_tracing_modeandconstruct_url, with a new fixture for a sampler with some transaction filters set.The source code was introduced in https://github.com/solarwindscloud/solarwinds-apm-python/pull/136/files and https://github.com/solarwindscloud/solarwinds-apm-python/pull/137/files.
EDIT: In b7180d5 I've renamed both sampler fixtures for general clarity and to try to make CodeQL happy.