Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-35046 No longer need PLATFORM env var for sdist installation, tests #119

Merged
merged 12 commits into from
Mar 8, 2023
2 changes: 0 additions & 2 deletions .github/actions/package_solarwinds_apm_x86_64/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ description: Package solarwinds_apm for x86_64
runs:
using: 'docker'
image: quay.io/pypa/manylinux_2_28_x86_64:latest
env:
PLATFORM: x86_64
entrypoint: 'make'
args:
- 'package'
2 changes: 0 additions & 2 deletions .github/workflows/run_tox_lint_format.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,3 @@ jobs:
run: make wrapper
- name: Run tox lint
run: tox -e lint -- --check-only
env:
PLATFORM: x86_64
2 changes: 0 additions & 2 deletions .github/workflows/run_tox_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,3 @@ jobs:
run: make wrapper
- name: Run tox
run: tox -e py3${{ matrix.python-minor }}-${{ matrix.apm-env }}
env:
PLATFORM: x86_64
38 changes: 0 additions & 38 deletions .github/workflows/verify_install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -71,7 +70,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -96,7 +94,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -121,7 +118,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -146,7 +142,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -171,7 +166,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -196,7 +190,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -221,7 +214,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -246,7 +238,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand All @@ -271,7 +262,6 @@ jobs:
run: |
sudo docker run \
--platform linux/arm64 \
-e PLATFORM=aarch64 \
-e MODE=${{ github.event.inputs.install-registry }} \
-e SOLARWINDS_APM_VERSION=${{ github.event.inputs.solarwinds-version }} \
-e SW_APM_COLLECTOR_AO_PROD=${{ secrets.SW_APM_COLLECTOR_AO_PROD }} \
Expand Down Expand Up @@ -302,7 +292,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py37_install_ubuntu1804:
Expand All @@ -317,7 +306,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py37_install_amazon2:
Expand All @@ -336,7 +324,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py37_install_alpine312:
Expand All @@ -351,7 +338,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py37_install_alpine313:
Expand All @@ -366,7 +352,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py37_install_alpine317:
Expand All @@ -381,7 +366,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

#--------------------------------------------------------------------
Expand All @@ -400,7 +384,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py38_install_ubuntu1804:
Expand All @@ -415,7 +398,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py38_install_ubuntu2004:
Expand All @@ -430,7 +412,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py38_install_alpine312:
Expand All @@ -445,7 +426,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py38_install_alpine313:
Expand All @@ -460,7 +440,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

#--------------------------------------------------------------------
Expand All @@ -479,7 +458,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py39_install_ubuntu2004:
Expand All @@ -494,7 +472,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py39_install_centos8:
Expand All @@ -509,7 +486,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py39_install_alpine312:
Expand All @@ -524,7 +500,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py39_install_alpine313:
Expand All @@ -539,7 +514,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py39_install_alpine316:
Expand All @@ -554,7 +528,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py39_install_alpine317:
Expand All @@ -569,7 +542,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py39_install_rhel8:
Expand All @@ -584,7 +556,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

#--------------------------------------------------------------------
Expand All @@ -603,7 +574,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py310_install_ubuntu2004:
Expand All @@ -618,7 +588,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py310_install_alpine313:
Expand All @@ -633,7 +602,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py310_install_alpine316:
Expand All @@ -648,7 +616,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py310_install_alpine317:
Expand All @@ -663,7 +630,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

#--------------------------------------------------------------------
Expand All @@ -682,7 +648,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py311_install_ubuntu2004:
Expand All @@ -697,7 +662,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py311_install_alpine316:
Expand All @@ -712,7 +676,6 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}

py311_install_alpine317:
Expand All @@ -727,5 +690,4 @@ jobs:
run: ./_helper_run_install_tests.sh
shell: sh
env:
PLATFORM: x86_64
MODE: ${{ github.event.inputs.install-registry }}
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased](https://github.com/solarwindscloud/solarwinds-apm-python/compare/rel-0.8.0...HEAD)
### Changed
- Fixed installation from source distribution ([#119](https://github.com/solarwindscloud/solarwinds-apm-python/pull/119))

## [0.8.0](https://github.com/solarwindscloud/solarwinds-apm-python/releases/tag/rel-0.8.0) - 2023-02-28

Expand Down
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,12 @@ nothing:
# variable definitions and recipes for downloading of required header and library files
#----------------------------------------------------------------------------------------------------------------------#

# Platform for builds and install testing: x86_64 or aarch64
# Platform for wheel tagging: x86_64 or aarch64
platform := ${PLATFORM}
ifeq (${platform},aarch64)
wheel_tag := manylinux_2_28_aarch64
else
platform := x86_64
wheel_tag := manylinux_2_28_x86_64
endif

Expand Down
4 changes: 0 additions & 4 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ services:
# tox for automated tests
python3.8 -m pip install boto3 twine tox
/bin/bash
environment:
- PLATFORM=x86_64

aarch64:
image: quay.io/pypa/manylinux_2_28_aarch64
Expand All @@ -50,5 +48,3 @@ services:
# tox for automated tests
python3.8 -m pip install boto3 twine tox
/bin/bash
environment:
- PLATFORM=aarch64
Loading