-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-12708 Add ARM support #111
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7ce44a4.
Oh no, Python 3.10 unit tests for "AO prod" failing 😑 Having a look EDIT: Yay fixed |
tammy-baylis-swi
force-pushed
the
NH-12708-arm-support
branch
from
February 10, 2023 23:42
6fdef13
to
226afbf
Compare
raphael-theriault-swi
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, probably worth getting another pair of eyes given the size though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds infra for ARM-compatible (
aarch64
) wheel builds and install tests.Example builds
Testrelease 0.7.0.4 with sdist,
x86_64
manylinux wheels, andaarch64
manylinux wheels onTestPyPI: https://test.pypi.org/project/solarwinds-apm/0.7.0.4/#files
PackageCloud: https://packagecloud.io/solarwinds/solarwinds-apm-python
I will test updated PyPI publish with the next APM release.
Install tests using 0.7.0.4 from TestPyPI and PackageCloud pass:
Key changes
build_publish_sdist_and_x86_64
GH jobs continue to build and uploadx86_64
wheels and the sdist to TestPyPI or PyPI, usingmanylinux_2_28_x86_64
.x86_64
andaarch64
liboboe.so
files.build_publish_aarch64
GH jobs use QEMU andmanylinux_2_28_aarch64
to buildaarch64
wheels and upload to TestPyPI or PyPI.aarch64
wheels.aarch64
, QEMU-run cases to Verify Installation workflow, as we are working on setting up self-hosted ARM test runners to replace these later."x86_64"
in builds and install tests with a new, requiredPLATFORM
environment variable (one of:"x86_64"
,"aarch64"
).x86_64
oraarch64
.run_docker_dev.sh
andDockerfile
are replaced by adocker-compose
to run either container locally withPLATFORM
and manylinux image set accordingly.CONTRIBUTING.md
.README.md
for running install test containers locally (e.g. on own Intel MacBook, or EC2 AARCH64 instance). Could alternatively add this toCONTRIBUTING.md
.The GH workflows using QEMU are slow but they seem to work and are less of a security concern than using uraimo/run-on-arch-action.
Please let me know if any suggestions!