NH-32409 Fix failed ASGI version lookup logs

CHANGELOG.md

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 - SolarWinds c-lib 12.0.0, for gRPC upgrade ([#107](https://github.com/solarwindscloud/solarwinds-apm-python/pull/107))
+- Bugfix: fix version lookup failures for instrumented ASGI libraries ([#108](https://github.com/solarwindscloud/solarwinds-apm-python/pull/108))
 
 ### Removed
 - Drop centos7 support ([#107](https://github.com/solarwindscloud/solarwinds-apm-python/pull/107))

solarwinds_apm/exporter.py

@@ -16,6 +16,7 @@
 from typing import Any
 
 from opentelemetry.sdk.trace.export import SpanExporter
+from opentelemetry.trace import SpanKind
 from pkg_resources import get_distribution
 
 from solarwinds_apm.apm_constants import (
@@ -36,6 +37,20 @@ class SolarWindsSpanExporter(SpanExporter):
     Initialization requires a liboboe reporter.
     """
 
+    _ASGI_APP_IMPLEMENTATIONS = [
+        "fastapi",  # based on starlette, so higher up
+        "starlette",
+        "channels",
+        "quart",
+        "sanic",
+        "rpc.py",
+        "a2wsgi",
+    ]
+    _ASGI_SERVER_IMPLEMENTATIONS = [
+        "uvicorn",
+        "hypercorn",
+        "daphne",
+    ]
     _INTERNAL_TRANSACTION_NAME = "TransactionName"
     _SW_SPAN_KIND = "sw.span_kind"
 
@@ -138,7 +153,7 @@ def _add_info_instrumentation_scope(self, span, evt) -> None:
                 INTL_SWO_OTEL_SCOPE_VERSION, span.instrumentation_scope.version
             )
 
-    # pylint: disable=too-many-branches
+    # pylint: disable=too-many-branches,too-many-statements
     def _add_info_instrumented_framework(self, span, evt) -> None:
         """Add info to span for which Python framework has been instrumented
         with OTel. Based on instrumentation scope of the span, if present.
@@ -159,6 +174,38 @@ def _add_info_instrumented_framework(self, span, evt) -> None:
                 framework = "psutil"
             elif framework == "tortoiseorm":
                 framework = "tortoise"
+            # asgi is implemented over multiple frameworks
+            # https://asgi.readthedocs.io/en/latest/implementations.html
+            # Use the first best guess framework for name and version
+            # TODO Increase precision
+            elif framework == "asgi":
+                if span.kind == SpanKind.SERVER:
+                    for asgi_impl in self._ASGI_SERVER_IMPLEMENTATIONS:
+                        try:
+                            importlib.import_module(asgi_impl)
+                        except (AttributeError, ImportError):
+                            continue
+                        else:
+                            logger.debug(
+                                "Setting %s as instrumented ASGI server framework span KV",
+                                asgi_impl,
+                            )
+                            framework = asgi_impl
+                            break
+                else:
+                    # SpanKind.INTERNAL might be common for async
+                    for asgi_impl in self._ASGI_APP_IMPLEMENTATIONS:
+                        try:
+                            importlib.import_module(asgi_impl)
+                        except (AttributeError, ImportError):
+                            continue
+                        else:
+                            logger.debug(
+                                "Setting %s as instrumented ASGI application framework span KV",
+                                asgi_impl,
+                            )
+                            framework = asgi_impl
+                            break
 
             instr_key = f"Python.{framework}.Version"
             if "grpc_" in framework: