Post big extract query #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adding PostBigExtractRequest plugin example - adding PostBigExtractRequest plugin documentation
Codecov Report
@@ Coverage Diff @@
## master #944 +/- ##
==========================================
+ Coverage 92.66% 92.70% +0.03%
==========================================
Files 336 337 +1
Lines 8267 8309 +42
==========================================
+ Hits 7661 7703 +42
Misses 606 606
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
thomascorthals
requested changes
Jul 12, 2021
thomascorthals
requested changes
Jul 15, 2021
There was a problem hiding this comment.
Thanks already for the changes!
Can you fill in the missing test coverage? This has a couple of benefits:
- It shows why the different code paths are necessary.
- It shows how the different code paths are reached.
- And of course it protects against breaking something in the future.
- 7.8-plugin-postbigextractrequest.php: deleted copyright comment - PostBigExtractRequestTest.php: lower maximum length and fewer fields
thomascorthals
requested changes
Jul 22, 2021
Test the literal expected raw data + full test coverage
thomascorthals
approved these changes
Jul 22, 2021
|
@mkalkbrenner I can look into an integration test after this gets merged. Don't have the time right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
#794 (comment)