Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes #1228

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Minor fixes #1228

merged 2 commits into from
Nov 18, 2024

Conversation

Metritutus
Copy link
Collaborator

  • Partial restoration of some changes from commit bad4f2a that were lost in a merge:
    • Fixed compare() method in gridHelper not actually treating null values as smaller than anything else when sorting.
  • Updated SvgWrapper to fully use the Composition API, and consolidated functionality to remove the need for SvgWrapperInternal.
  • Fixed some StarIcon CSS classes not applying.
  • Fixed image StarIcons not showing in older webkit-based browsers.

SpacialCircumstances and others added 2 commits November 4, 2024 22:40
@SpacialCircumstances
Merge pull request solaris-games#1220 from solaris-games/dev
c09b539 
Dev 247.1
@Metritutus
* Partial restoration of some changes from commit bad4f2a that were l…
2480000 
…ost in a merge:

    - Fixed compare() method in gridHelper not actually treating null values as smaller than anything else when sorting.
* Updated SvgWrapper to fully use the Composition API, and consolidated functionality to remove the need for SvgWrapperInternal.
* Fixed some StarIcon CSS classes not applying.
* Fixed image StarIcons not showing in older webkit-based browsers.
@SpacialCircumstances SpacialCircumstances changed the base branch from master to dev November 18, 2024 20:04
@SpacialCircumstances SpacialCircumstances merged commit 36ffcff into solaris-games:dev Nov 18, 2024
1 check passed
@SpacialCircumstances SpacialCircumstances added this to the Update 248 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Update 248
Development

Successfully merging this pull request may close these issues.
2 participants
@Metritutus @SpacialCircumstances