Idempotency changes #1103
Merged
Idempotency changes #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Metritutus
commented
Jul 21, 2024
Metritutus
commented
- Added idempotent functionality to all unsafe HTTP method requests, to prevent requests like POST, PUT, etc from being actioned multiple times in instances where, say, the client may be retrying a request due to it not receiving feedback from the server due to connection issues (eg poor mobile signal, etc). This should fix instances where a player may accidentally buy multiple carriers where they only meant to buy one, or accidentally create two conversations with the same player, etc.
- Updated carrier gift modal wording to make clear that the specialist will be retired if the destination star does not belong to an ally.
- Updated express.ts to remove unnecessary setting of cors Access-Control-Allow-Headers (it was being replaced by the line directly below it anyway).
Fix scheduled bulk upgrades checking for wrong tick
Fix to reevaluate scheduled actions even in ticks where none are active (Hotfix for 242)
…to prevent requests like POST, PUT, etc from being actioned multiple times in instances where, say, the client may be retrying a request due to it not receiving feedback from the server due to connection issues (eg poor mobile signal, etc). This should fix instances where a player may accidentally buy multiple carriers where they only meant to buy one, or accidentally create two conversations with the same player, etc. * Updated carrier gift modal wording to make clear that the specialist will be retired if the destination star does not belong to an ally. * Updated express.ts to remove unnecessary setting of cors Access-Control-Allow-Headers (it was being replaced by the line directly below it anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.