This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Cargo check all targets #9718
Merged
Cargo check all targets #9718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Apr 25, 2020
| @@ -13,7 +13,7 @@ export RUSTFLAGS="-D warnings" | |||
| # Look for failed mergify.io backports | |||
| _ git show HEAD --check --oneline | |||
|
|
|||
| if _ scripts/cargo-for-all-lock-files.sh check --locked; then | |||
| if _ scripts/cargo-for-all-lock-files.sh +"$rust_nightly" check --locked --all-targets; then | |||
There was a problem hiding this comment.
+"$rust_nightly" needed for this: https://buildkite.com/solana-labs/solana/builds/23350#c4cb3312-b32d-42b1-bda2-1e2cdc091a4b/70-475
Checking solana-ownable v1.2.0 (/solana/programs/ownable)
Checking solana-btc-spv-program v1.2.0 (/solana/programs/btc_spv)
error[E0554]: `#![feature]` may not be used on the stable release channel
--> sdk/benches/slot_history.rs:1:1
|
1 | #![feature(test)]
| ^^^^^^^^^^^^^^^^^
error[E0554]: `#![feature]` may not be used on the stable release channel
--> sdk/benches/slot_hashes.rs:1:1
|
1 | #![feature(test)]
| ^^^^^^^^^^^^^^^^^
error[E0554]: `#![feature]` may not be used on the stable release channel
--> sdk/benches/short_vec.rs:1:1
|
1 | #![feature(test)]
| ^^^^^^^^^^^^^^^^^
error: aborting due to previous error
ryoqun
commented
Apr 25, 2020
| @@ -26,7 +26,7 @@ if [[ -n $escape_marker && ${#shifted_args[@]} -gt 0 ]]; then | |||
| done | |||
| shifted_args=() | |||
| else | |||
| files="$(git ls-files :**/Cargo.lock)" | |||
There was a problem hiding this comment.
;)
... and we got 375fad1
ryoqun
commented
Apr 25, 2020
| @@ -3482,6 +3478,24 @@ name = "shlex" | |||
| version = "0.1.1" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
|
|
|||
| [[package]] | |||
Codecov Report
@@ Coverage Diff @@
## master #9718 +/- ##
========================================
+ Coverage 80.5% 80.6% +0.1%
========================================
Files 279 279
Lines 63839 63839
========================================
+ Hits 51429 51506 +77
+ Misses 12410 12333 -77 |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I'm no fan of waitng 10-20 mins only to find a compilation error after
coverageandstableCI job, while wasting our precious CI resources...Summary of Changes
Do fail more early for compilation errors by
cargo check-ing all our.rssources!spin-off from #9527