This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Refactoring for rollback #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasons Transaction signatures need to be unique: 1. guard against duplicates 2. accountant uses them as IDs to link Witness signatures to transactions via the `pending` hash map
It doesn't really matter, but was confusing since the seed points to an entry before the mint's deposit.
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 93.79% 93.69% -0.11%
==========================================
Files 15 15
Lines 1145 1110 -35
==========================================
- Hits 1074 1040 -34
+ Misses 71 70 -1
Continue to review full report at Codecov.
|
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
willhickey
pushed a commit
that referenced
this pull request
Mar 9, 2024
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Mar 11, 2024
…s#33990) (solana-labs#97) Display error message while laoding geyser plugins (solana-labs#33990) Co-authored-by: galactus <96341601+godmodegalactus@users.noreply.github.com>
godmodegalactus
added a commit
to blockworks-foundation/solana
that referenced
this pull request
Apr 16, 2024
Changing the defaults for ScanConfig v1.17: ignore mio audit report (solana-labs#76) ci: ignore mio audit v1.17: Display error message while loading geyser plugins (solana-labs#33990) (solana-labs#97) Display error message while laoding geyser plugins (solana-labs#33990) Co-authored-by: galactus <96341601+godmodegalactus@users.noreply.github.com> v1.17: Remove unnecessary unwrap from `simulate_transaction_unchecked()` (backport of solana-labs#35375) (solana-labs#65) Remove unnecessary unwrap from `simulate_transaction_unchecked()` (solana-labs#35375) Remove unnecessary unwrap from simulate_transaction_unchecked() (cherry picked from commit cb260f1) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
segfaultdoc
pushed a commit
to jito-labs/solana
that referenced
this pull request
Aug 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoupled accounting from writing new entries to the ledger.