This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Rpc: Add getConfirmedTransaction #9381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9381 +/- ##
========================================
- Coverage 81.1% 81.1% -0.1%
========================================
Files 276 276
Lines 62075 62168 +93
========================================
+ Hits 50389 50457 +68
- Misses 11686 11711 +25 |
mvines
approved these changes
Apr 9, 2020
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2020
* Add blockstore method to return a complete transaction by signature * Plumb getConfirmedTransaction rpc * Add doc (cherry picked from commit e1aa247)
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2020
* Add blockstore method to return a complete transaction by signature * Plumb getConfirmedTransaction rpc * Add doc (cherry picked from commit e1aa247)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 9, 2020
solana-grimes
pushed a commit
that referenced
this pull request
Apr 9, 2020
danpaul000
pushed a commit
to danpaul000/solana
that referenced
this pull request
Jul 8, 2020
* Add blockstore method to return a complete transaction by signature * Plumb getConfirmedTransaction rpc * Add doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's not possible to fetch the details of a specific transaction from an API node unless you happen to know the Slot it was processed in (for
getConfirmedBlock). Now that we have a performant way to query statuses by Signature, we can offer a more targeted approach.Summary of Changes
Blockstore::get_transaction_statusgetConfirmedTransactionRPC endpoint and hook up to blockstore. As implied by the endpoint name,getConfirmedTransactionwill only return details for transactions in rooted blocks.Toward #9317