-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Sanitize zero lamport accounts in append vecs #9083
Sanitize zero lamport accounts in append vecs #9083
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9083 +/- ##
======================================
Coverage 80.5% 80.5%
======================================
Files 269 269
Lines 58946 58970 +24
======================================
+ Hits 47462 47484 +22
- Misses 11484 11486 +2 |
@ryoqun - did you observe a problem with the current TdS cluster here? |
@mvines Yeah, that's because TdS cluster still holds ill-state zero lamport accounts before we had #8657.. I'm purging it by |
The bad ones are like this (Note that
|
Now, I've fixed all those! @sakridge Prime time for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
(cherry picked from commit 729cc4e)
(this hampers TdS snapshot restore as it contain some now-illegalized account data; I'm planning to fix it against the live TdS cluster)(fixed that)Problem
Snapshot can contain any state for 0 lamport accounts, which can be exposed to the runtime. And cause cluster forks like did #8590.
Summary of Changes
Like #8657, which normalized the account state when saving, this pr does sanitize the account state when restored from snapshot.
Part of #7167