This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Cli: Fix create-with-seed #8706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garious , after this lands, this works: |
|
Can't fix a regression without a test. |
CriesofCarrots
force-pushed
the
create-with-seed
branch
from
404075f to
f103fca
Compare
CriesofCarrots
force-pushed
the
create-with-seed
branch
from
f103fca to
269ad75
Compare
✔️ |
Codecov Report
@@ Coverage Diff @@
## master #8706 +/- ##
========================================
- Coverage 80.0% 80.0% -0.1%
========================================
Files 260 260
Lines 56399 56460 +61
========================================
+ Hits 45164 45212 +48
- Misses 11235 11248 +13 |
t-nelson
approved these changes
Mar 9, 2020
| let config_pubkey = config.pubkey()?; | ||
| let from_pubkey = from_pubkey.unwrap_or(&config_pubkey); | ||
| let address = create_address_with_seed(from_pubkey, seed, program_id)?; | ||
| let from_pubkey = if let Some(pubkey) = from_pubkey { |
There was a problem hiding this comment.
Can't use ? in a closure that returns a Pubkey, so the current construction seems simpler to me for the else case.
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2020
* Add failing test * Fix create-address-with-seed regression * Add apis to enable generating a pubkey from all various signers * Enable other signers as --from in create-with-seed (cherry picked from commit eab80d0)
solana-grimes
pushed a commit
that referenced
this pull request
Mar 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana create-with-seed ...errors our no matter what from or config keypair is provided.Also, users might want to derive keys from any kind of signer, including hardware wallets or seed phrases, and there is currently no support for that.
Summary of Changes
--fromand config keypair setting appropriately to fix subcommandpubkey_of_signer()method to generate a pubkey from any kind of acceptable signer and use to extend create-with-seed functionality (we may want to use this method in other cli subcommands; will examine and pr separately)Fixes #8696