This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Rename slot_hash => bank_hash in AcoountsDB #7579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryoqun
commented
Dec 20, 2019
| if calculated_hash == *found_hash { | ||
| Ok(()) | ||
| } else { | ||
| Err(MismatchedBankHash) | ||
| } | ||
| } else { | ||
| Err(BankHashVerificatonError::MissingBankHash) |
There was a problem hiding this comment.
Err, this escaped from my eyes. And this is against my aesthetics.
|
CI now fails because of timeout.... Even with this kind of tiny PR...... |
Codecov Report
@@ Coverage Diff @@
## master #7579 +/- ##
=========================================
+ Coverage 70.3% 80.8% +10.4%
=========================================
Files 244 244
Lines 57859 50353 -7506
=========================================
+ Hits 40706 40712 +6
+ Misses 17153 9641 -7512 |
ryoqun
commented
Dec 20, 2019
ci/buildkite.yml
Outdated
| @@ -20,7 +20,7 @@ steps: | |||
| timeout_in_minutes: 30 | |||
| - command: ". ci/rust-version.sh; ci/docker-run.sh $$rust_stable_docker_image ci/test-stable.sh" | |||
| name: "stable" | |||
| timeout_in_minutes: 40 | |||
| timeout_in_minutes: 50 | |||
There was a problem hiding this comment.
Evil commit prevails.....
This reverts commit 8348958.
mergify
bot
dismissed
sakridge’s stale review
Pull request has been modified.
|
The CI build for the latest commit was failed but I'm merging this anyway because this PR does actually passed the CI. The CI has just timed-out and this PR actually has passed the CI at the previous commit. |
sakridge
pushed a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
* Rename slot_hash => bank_hash in AcoountsDB
sakridge
pushed a commit
to sakridge/solana
that referenced
this pull request
Jan 14, 2020
* Rename slot_hash => bank_hash in AcoountsDB
mvines
pushed a commit
that referenced
this pull request
Jan 15, 2020
* Rename slot_hash => bank_hash in AcoountsDB
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick follow-up PR as per this:
(Remotely) part of #7167