Cleanup get balance #723
Merged
Cleanup get balance #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't congest a congested network.
|
Awesome! |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…-labs#723) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.2 to 14.14.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 11, 2024
…#716) (solana-labs#723) * default staked client in LocalCluster (solana-labs#716) * default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <apfitzge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poll_get_balance()predates the thin client's ability to confirm a transaction. It is frequently being misused after sending a transaction to wait for the transaction to be processed, rather than its intent, which is to do retries to guard against the case where aRequestUDP packet is dropped. To confirm a transaction was processed, you should confirm its signature. This PR adds a new functionpoll_for_signature()and uses it to update a few of the spots wherepoll_get_balance()was being used to confirm a transaction.