Install llvm-cov on nightly to revive coverage #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes seem fine to me. I see CI is green but it looks like the image at https://hub.docker.com/r/solanalabs/rust-nightly/tags/ doesn't contain the changes here so not sure that CI actual validated anything new here. |
|
Would be nice to get an up-to-date coverage number on the README badge when we release. Merging. Feel free to revert if any sign of trouble. |
|
I manually ran https://buildkite.com/solana-labs/solana-ci-docker-rust-nightly/builds/3 to update the image on dockerhub |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* Added address type in programm address generation for the stake pool, renamed nonce to bump seed * Formatting fixed * Bump seed calculation moved to the smart contract, test for fee > 1 added, state length public constant added * Added claim method to stake pool, fixed program address generation in token mint and burn calls * Refactored signers management when calling other contracts * Signers formation put back into calling functions, deposit/withdraw/claim method reworked, state serialization bug fixed * Added instruction interface methods * Fixed signer flags for accounts in stake pool instruction creation
AshwinSekar
pushed a commit
to AshwinSekar/solana
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this works.
docker runfailing for unrelated reasons locally. These are the commands it took to get llvm-cov 6.0 installed, which is the version thecargo covREADME recommends installing on Ubuntu/Debian.Towards #433