This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Hash anything signed #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively, we could remove hash IDs from everything but Ticks, and have the tick hash all entries since the last tick. |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 12 12
Lines 720 720
=======================================
Hits 667 667
Misses 53 53
Continue to review full report at Codecov.
|
|
I don't like this fix, closing. I'd rather remove hashes than add them. #61 |
CriesofCarrots
pushed a commit
that referenced
this pull request
Feb 28, 2020
mvines
referenced
this pull request
in mvines/solana
Jun 15, 2020
mvines
pushed a commit
that referenced
this pull request
Jun 15, 2020
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
bw-solana
added a commit
to bw-solana/solana
that referenced
this pull request
Mar 4, 2024
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Mar 5, 2024
) update mio to 0.8.11 (solana-labs#60) (cherry picked from commit f591210) Co-authored-by: Brennan <brennan.watt@anza.xyz>
yihau
added a commit
to yihau/solana
that referenced
this pull request
Mar 5, 2024
…ana-labs#71)" This reverts commit 9b784a2.
willhickey
pushed a commit
that referenced
this pull request
Mar 5, 2024
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Mar 8, 2024
* Revert "v1.18: update mio to 0.8.11 (backport of solana-labs#60) (solana-labs#71)" This reverts commit 9b784a2. * ci: ignore mio audit
willhickey
pushed a commit
that referenced
this pull request
Mar 9, 2024
willhickey
pushed a commit
that referenced
this pull request
Mar 9, 2024
willhickey
pushed a commit
that referenced
this pull request
Mar 9, 2024
willhickey
pushed a commit
that referenced
this pull request
Mar 9, 2024
segfaultdoc
pushed a commit
to jito-labs/solana
that referenced
this pull request
Aug 7, 2024
ghost
pushed a commit
to blockworks-foundation/solana
that referenced
this pull request
Dec 5, 2024
* Revert "v1.18: update mio to 0.8.11 (backport of solana-labs#60) (solana-labs#71)" This reverts commit 9b784a2. * ci: ignore mio audit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the first entry in the log is allowed to have zero hashes.