Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

Generate a wallet-specific mint.json? #505

Closed
wants to merge 1 commit into from

Conversation

mvines
Copy link
Contributor

@mvines mvines commented Jun 30, 2018

Follow-up to #503, maybe towards #502.

@garious
Copy link
Contributor

garious commented Jun 30, 2018

With this change, it looks like the user should no longer need to invoke setup.sh before wallet.sh. Is that the intent?

@mvines
Copy link
Contributor Author

mvines commented Jun 30, 2018

It wasn't necessary to run setup.sh to use wallet.sh before this PR actually

Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better short-term fix would be to use solana-mint to generate client.json so that when you run the wallet against a local leader, it works the same as if the leader were on another host. It'll also make it easier to incrementally move to a client.key with a different encoding.

@garious garious closed this Jun 30, 2018
lijunwangs pushed a commit to lijunwangs/solana that referenced this pull request Apr 7, 2024
…s#321) (solana-labs#505)

add metric for duplicate push messages (solana-labs#321)

* add metric for duplicate push messages

* add in num_total_push

* address comments. don't lock stats each time

* address comments. remove num_total_push

* change dup push message name in code to reflect metric name

(cherry picked from commit 04feed2)

Co-authored-by: Greg Cusack <greg.cusack@anza.xyz>
willhickey pushed a commit that referenced this pull request Apr 8, 2024
add metric for duplicate push messages (#321)

* add metric for duplicate push messages

* add in num_total_push

* address comments. don't lock stats each time

* address comments. remove num_total_push

* change dup push message name in code to reflect metric name

(cherry picked from commit 04feed2)

Co-authored-by: Greg Cusack <greg.cusack@anza.xyz>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants