Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Update replicators to use a blockhash to generate offsets #4712

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

sagar-solana
Copy link
Contributor

@sagar-solana sagar-solana commented Jun 17, 2019

Problem

Replicators use their encryption keys to generate offsets. This results in the same offsets for every proof.

Summary of Changes

Rotate the offsets based on a recent blockhash.
Minor fn renaming

Fixes #

@sagar-solana sagar-solana requested a review from sakridge June 17, 2019 22:54
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #4712 into master will increase coverage by 3.2%.
The diff coverage is 85.7%.

@@           Coverage Diff            @@
##           master   #4712     +/-   ##
========================================
+ Coverage    75.1%   78.3%   +3.2%     
========================================
  Files         184     184             
  Lines       34706   33245   -1461     
========================================
- Hits        26065   26059      -6     
+ Misses       8641    7186   -1455

1 similar comment
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #4712 into master will increase coverage by 3.2%.
The diff coverage is 85.7%.

@@           Coverage Diff            @@
##           master   #4712     +/-   ##
========================================
+ Coverage    75.1%   78.3%   +3.2%     
========================================
  Files         184     184             
  Lines       34706   33245   -1461     
========================================
- Hits        26065   26059      -6     
+ Misses       8641    7186   -1455

@sagar-solana sagar-solana merged commit 8fbf0e2 into solana-labs:master Jun 17, 2019
@sagar-solana sagar-solana deleted the fix_offsets branch June 17, 2019 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant