This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Fix storage program space issues and limit storage transaction data #4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvines take a look at the wallet changes. I think I did the right thing. (including the pretty print for the account data; maybe I should have done it for all account prints?) |
Codecov Report
@@ Coverage Diff @@
## master #4677 +/- ##
========================================
+ Coverage 71.6% 75.5% +3.8%
========================================
Files 184 184
Lines 35910 34096 -1814
========================================
+ Hits 25732 25754 +22
+ Misses 10178 8342 -1836 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4677 +/- ##
========================================
+ Coverage 71.6% 75.5% +3.8%
========================================
Files 184 184
Lines 35910 34096 -1814
========================================
+ Hits 25732 25754 +22
+ Misses 10178 8342 -1836 |
sakridge
reviewed
Jun 14, 2019
| // The maximum transaction size is == `PACKET_DATA_SIZE` (1232 bytes) | ||
| // There are approx. 900 bytes left over after the storage instruction is wrapped into | ||
| // a signed transaction. | ||
| static MAX_BYTES: u64 = 900; |
There was a problem hiding this comment.
Should we do something like PACKET_DATA_SIZE - 300
There was a problem hiding this comment.
Yeah maybe that is better. I'll fix it the next time I push something.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Storage accounts can fill up quite easily and it's possible for validators to be unable to submit some proof of validation transactions if there are too many replicators and proofs in a turn/segment
Summary of Changes
Numerous updates to storage accounts and storage program
Fixes #4536