This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add tick height syscall #4497
Merged
Add tick height syscall #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
force-pushed
the
tick-height-syscall
branch
from
5f9a2ae to
4dbc02d
Compare
mvines
reviewed
May 31, 2019
CriesofCarrots
force-pushed
the
tick-height-syscall
branch
2 times, most recently
from
8bd41e8 to
7cd0271
Compare
Codecov Report
@@ Coverage Diff @@
## master #4497 +/- ##
=========================================
+ Coverage 67.8% 79.5% +11.6%
=========================================
Files 179 180 +1
Lines 37556 32101 -5455
=========================================
+ Hits 25472 25522 +50
+ Misses 12084 6579 -5505 |
CriesofCarrots
force-pushed
the
tick-height-syscall
branch
from
7cd0271 to
179746f
Compare
rob-solana
approved these changes
May 31, 2019
mvines
approved these changes
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
tick_heightwas added to the program entrypoint expressly for the tic-tac-toe example, but it's no longer really used. Also, we have syscalls now.Summary of Changes
Removes tick_height from program entrypoint signature
Adds tick_height syscall and taps for storage program
Fixes #4482