Add support for local metric collection/viewing #4170
Conversation
|
Seeing this patch, the goodness under |
|
@danpaul000 should review this too, I added him |
metrics/scripts/enable.sh
Outdated
| export INFLUX_USERNAME=admin | ||
| export INFLUX_PASSWORD=admin | ||
|
|
||
| export SOLANA_METRICS_CONFIG="host=$INFLUX_HOST,db=$INFLUX_DATABASE,u=$INFLUX_USERNAME,p=$INFLUX_PASSWORD" |
There was a problem hiding this comment.
how about just setting this env var, then running scripts/configure-metrics.sh to set all the INFLUX vars...less places to change in the future
There was a problem hiding this comment.
Seemed weird to call over to configure-metrics.sh. Maybe should move configure-metrics.sh and metrics-write-datapoint.sh to /metrics/scripts
There was a problem hiding this comment.
Moving seems better longer term but that's gonna cause some painful churn. I vote to call down for now with a TODO in this file to consider moving those two scripts later
metrics/scripts/start.sh
Outdated
| --volume "$PWD"/influxdb.conf:/etc/influxdb/influxdb.conf:ro \ | ||
| --volume "$PWD"/lib/influxdb:/var/lib/influxdb \ | ||
| -e INFLUXDB_DB=local \ | ||
| -e INFLUXDB_ADMIN_USER=admin \ |
There was a problem hiding this comment.
nit: fix indent. Also use long arg, --env for consistency
|
@mvines Think we should move this local metrics stuff into |
Too nested! Instead I want to generalize |
Problem
Summary of Changes
Fixes #