This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
ci: Add cleanup script to manage build agent disk space #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
approved these changes
Jun 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 91.06% 90.78% -0.29%
==========================================
Files 36 36
Lines 3493 3493
==========================================
- Hits 3181 3171 -10
- Misses 312 322 +10
Continue to review full report at Codecov.
|
rob-solana
reviewed
Jun 19, 2018
| # Regular maintenance performed on a buildkite agent to control disk usage | ||
| # | ||
|
|
||
| echo --- Delete all exited containers first |
There was a problem hiding this comment.
prefer printf BUILTIN to echo
rob-solana
reviewed
Jun 19, 2018
| ( | ||
| set -x | ||
| exited=$(docker ps -aq --no-trunc --filter "status=exited") | ||
| if [[ -n "$exited" ]]; then |
There was a problem hiding this comment.
double quotes unnecessary in bash's builtin [[
rob-solana
reviewed
Jun 19, 2018
| set -x | ||
| dangling=$(docker images --filter 'dangling=true' -q --no-trunc | sort | uniq) | ||
| if [[ -n "$dangling" ]]; then | ||
| docker rmi "$dangling" |
There was a problem hiding this comment.
looks to me like dangling is multiple strings... when you pass "$dangling" to docker rmi, you pass a single argument
consider
dangling=( $(docker ...) )
docker rmi "${dangliing[@]}"
rob-solana
reviewed
Jun 19, 2018
| echo "--- Delete /tmp files older than 1 day owned by $(whoami)" | ||
| ( | ||
| set -x | ||
| find /tmp -maxdepth 1 -user "$(whoami)" -mtime +1 -print0 | xargs -0 rm -rf |
There was a problem hiding this comment.
whoami isn't always around, as such introduces a dependency, consider ${USER} or
CriesofCarrots
pushed a commit
that referenced
this pull request
Feb 28, 2020
mvines
added a commit
to mvines/solana
that referenced
this pull request
Jun 15, 2020
mvines
added a commit
that referenced
this pull request
Jun 15, 2020
yhchiang-sol
added a commit
to yhchiang-sol/solana
that referenced
this pull request
Mar 22, 2024
yhchiang-sol
added a commit
to yhchiang-sol/solana
that referenced
this pull request
Mar 22, 2024
yhchiang-sol
added a commit
to yhchiang-sol/solana
that referenced
this pull request
Mar 22, 2024
pgarg66
referenced
this pull request
in pgarg66/solana
Mar 22, 2024
…torage (anza-xyz#381) #### Problem The current implementation of TieredStorage::file_size() requires a sys-call to provide the file size. #### Summary of Changes Add len() API to TieredStorageReader, and have HotStorageReader() implement the API using Mmap::len(). #### Test Plan Update existing unit-test to also verify HotStorageReader::len().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker containers/images in particular need to be actively pruned to avoid running out of disk