Logs the number of storages kept alive by fastboot #34667
Conversation
| fastboot_storages = Some(snapshot_storages_for_fastboot); | ||
| datapoint_info!( | ||
| "fastboot", | ||
| ("slot", slot, i64), | ||
| ("num_storages", num_storages, i64), | ||
| ("num_storages_total", num_storages_total, i64), | ||
| ("num_storages_kept_alive", num_storages_kept_alive, i64), |
There was a problem hiding this comment.
I also thought about naming this num_storages_unique, but I wasn't confident that would be sufficient clear to others without looking at the code. Let me know if there's a better name.
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34667 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222394 222396 +2
=======================================
+ Hits 181957 181981 +24
+ Misses 40437 40415 -22 |
(cherry picked from commit e84974c)
Problem
We log the number of storages kept alive, but this is the total number of storages. Many of them are not kept alive only because of fastboot. I often want to know how many storages are uniquely kept alive by fastboot.
Summary of Changes
Add a datapoint for the number of storages kept alive just by fastboot.