Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: pin ahash to 0.8.4 #34636

Merged
merged 1 commit into from
Jan 3, 2024
Merged

v1.17: pin ahash to 0.8.4 #34636

merged 1 commit into from
Jan 3, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Jan 3, 2024

Problem

the error:
https://buildkite.com/solana-labs/solana/builds/106180#018ccc86-c779-4137-926a-13d3f3752bb4

the convo:
https://discord.com/channels/428295358100013066/560503042458517505/1191428671303598242

Summary of Changes

pin ahash to 0.8.4 (0.8.3 has been yanked and solana-frozen-abi is using 0.8.4)

@yihau yihau force-pushed the pin-ahash-version branch from 000bf30 to 5b06e46 Compare January 3, 2024 04:45
@yihau yihau marked this pull request as ready for review January 3, 2024 05:24
@yihau yihau added the automerge Merge this Pull Request automatically once CI passes label Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cc7c59a) 81.7% compared to head (5b06e46) 81.7%.
Report is 1 commits behind head on v1.17.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34636     +/-   ##
=========================================
- Coverage    81.7%    81.7%   -0.1%     
=========================================
  Files         805      805             
  Lines      218635   218635             
=========================================
- Hits       178810   178776     -34     
- Misses      39825    39859     +34     

Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@yihau
Copy link
Member Author

yihau commented Jan 3, 2024

I will merge this PR manually. Mergify is having a hard time 😞
Screenshot 2024-01-03 at 14 27 46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants