disables turbine and repair QUIC endpoints on mainnet-beta #34523
Conversation
On mainnet-beta, respective QUIC endpoint are unnecessary for now until testnet has fully migrated to QUIC. The commit disables turbine and repair QUIC endpoints on mainnet-beta.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #34523 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 822 822
Lines 221504 221522 +18
=======================================
+ Hits 181289 181372 +83
+ Misses 40215 40150 -65 |
| @@ -1170,58 +1170,74 @@ impl Validator { | |||
| // Outside test-validator crate, we always need a tokio runtime (and | |||
| // the respective handle) to initialize the turbine QUIC endpoint. | |||
| let current_runtime_handle = tokio::runtime::Handle::try_current(); | |||
| let turbine_quic_endpoint_runtime = current_runtime_handle.is_err().then(|| { | |||
There was a problem hiding this comment.
"Hide whitespace" for easier code review.
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
|
Do you expect to roll quic for repair and turbine out to mainnet-beta in v1.18? Will it be a gradual rollout like Merkle shreds? |
Not clear at the moment, because firedancer folks are proposing an alternative to QUIC and we will see how that would work out.
Any protocol changes will definitely be a gradual rollout. e.g. starting with small % of slots and ramping up. |
On mainnet-beta, respective QUIC endpoint are unnecessary for now until testnet has fully migrated to QUIC. The commit disables turbine and repair QUIC endpoints on mainnet-beta. (cherry picked from commit 4feadbd) # Conflicts: # core/src/validator.rs
…ckport of #34523) (#34526) * disables turbine and repair QUIC endpoints on mainnet-beta (#34523) On mainnet-beta, respective QUIC endpoint are unnecessary for now until testnet has fully migrated to QUIC. The commit disables turbine and repair QUIC endpoints on mainnet-beta. (cherry picked from commit 4feadbd) # Conflicts: # core/src/validator.rs * resolves mergify merge conflicts --------- Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Problem
On mainnet-beta, respective QUIC endpoint are unnecessary for now until testnet has fully migrated to QUIC.
Summary of Changes
The commit disables turbine and repair QUIC endpoints on mainnet-beta.