Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

try to reduce boilerplate #3422

Closed

Conversation

rob-solana
Copy link
Contributor

for discussion

@rob-solana
Copy link
Contributor Author

@garious @mvines

@garious
Copy link
Contributor

garious commented Mar 21, 2019

No dice. That whole module is moving to the _api crate. If CI wasn't so damn slow today, it'd already be done.

@rob-solana
Copy link
Contributor Author

rob-solana commented Mar 21, 2019

more interested in what you thought of the approach

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #3422 into master will increase coverage by <.1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #3422     +/-   ##
========================================
+ Coverage    79.7%   79.7%   +<.1%     
========================================
  Files         146     146             
  Lines       23095   23095             
========================================
+ Hits        18417   18424      +7     
+ Misses       4678    4671      -7

@garious
Copy link
Contributor

garious commented Mar 21, 2019

Love the approach. It'll be a little harder than that across crates. Have you done the C-preprocessor equivalent of ## in Rust macros?

@rob-solana
Copy link
Contributor Author

Love the approach. It'll be a little harder than that across crates. Have you done the C-preprocessor equivalent of ## in Rust macros?

in another life (3 months ago)... will look at your polished config and budget for further inspiration

@rob-solana rob-solana closed this Mar 22, 2019
@rob-solana rob-solana deleted the understand-programs branch April 1, 2019 21:40
joncinque pushed a commit to joncinque/solana that referenced this pull request Nov 13, 2024
* remove solana-sdk from solana-zk-token-sdk

* post-rebase fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants