Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

v1.16: validator: deprecates --disable-accounts-disk-index (backport of #33850) #34069

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 14, 2023

This is an automatic backport of pull request #33850 done by Mergify.
Cherry-pick of c55a6e5 has failed:

On branch mergify/bp/v1.16/pr-33850
Your branch is up to date with 'origin/v1.16'.

You are currently cherry-picking commit c55a6e55a1.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   validator/src/cli.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the conflicts label Nov 14, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #34069 (c653037) into v1.16 (1776575) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.16   #34069     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         766      766             
  Lines      209076   209075      -1     
=========================================
- Hits       171168   171100     -68     
- Misses      37908    37975     +67     

* validator: deprecates `--disable-accounts-disk-index`

* Fix checks failure

* Move disable_accounts_disk_index arg to alphabetical order

---------

Co-authored-by: Will Hickey <will.hickey@solana.com>
(cherry picked from commit c55a6e5)

# Conflicts:
#	validator/src/cli.rs
@t-nelson t-nelson force-pushed the mergify/bp/v1.16/pr-33850 branch from 8e60627 to c653037 Compare November 15, 2023 20:31
@t-nelson t-nelson merged commit bbc71be into v1.16 Nov 16, 2023
18 checks passed
@t-nelson t-nelson deleted the mergify/bp/v1.16/pr-33850 branch November 16, 2023 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants